[feature] set up allowed class-permissions to JEXL constructor#154
Open
Milchreis wants to merge 9 commits intoapache:masterfrom
Open
[feature] set up allowed class-permissions to JEXL constructor#154Milchreis wants to merge 9 commits intoapache:masterfrom
Milchreis wants to merge 9 commits intoapache:masterfrom
Conversation
…e custom classes in scripts
garydgregory
requested changes
Sep 28, 2023
Member
garydgregory
left a comment
garydgregory
left a comment
There was a problem hiding this comment.
@Milchreis
Thank you for your PR ! 😀
Please see my comments.
src/main/java/org/apache/commons/scxml2/env/jexl/JexlEvaluator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/commons/scxml2/env/jexl/JexlEvaluator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/commons/scxml2/env/jexl/JexlEvaluator.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi,
I had some trouble by using commons-scxml, because JEXL doesn't know my objects. Unfortunately JEXL is not very verbose and I took some time to understand that there are permissions.
commons-scxmlhas no "easy" way to add some custom permissions and it needs a deeper understanding to see that the JexlEvaluator has to derive with an overriddencreateJexlEngine-method.This PR contains a new constructor for JexlEvaluator which allows a custom set of classes which is used in
createJexlEngine(). Moreover there is a test now, which supportes the usage of classes outside the allowed java- and sxcml2-packages.I hope it finds a way into this great library 😊